Open
Conversation
Collaborator
Author
|
@dmwit, I also commited |
Collaborator
Author
|
By making similar |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is first step for #23
I introduce
Univnewtype, so instance definitions could be done based on combinators onUniv.Also I change indentation to use spaces.
Follow-ups would be:
universeoruniverseFin instance declarationsData.Universe.HelpersUnivimplementationOpen questions:
universeanduniverseFdon't need to be in the class anymore. Then we won't accidentally memoise when using them!Monoidinstance forUniv(using fair interleaving?)toList!)Univ, maybeDistinctorUSet?Data.Universe.HelperstoData.Universe.UnivSome answers:
2as this is huge update.universe-base(i.e. combinator removal, or even redefining ofUniv) won't breakuniverse-instance-*API. AsUnivisn't exported from instance packages, their public api isn't broken (if they continue to work). So we can depend onuniverse-instances-* >= 2 && <3. That could be documented inuniversepackage haddock if this scheme makes sense.